Open
Conversation
casparvanderheiden-tomtom
requested review from
BrunoCicciarello-TomTom,
FelixFaassen-TomTom and
johanvanderboom-tomtom
|
@casparvanderheiden-tomtom yes great. One little thing, make sure you do not commit CODEOWNERS to upstream PR's hahah but as I understood that will not happen ;-) Thanks Caspar and have a lovely day! |
FelixFaassen-TomTom
approved these changes
Jun 29, 2022
FelixFaassen-TomTom
left a comment
FelixFaassen-TomTom
left a comment
There was a problem hiding this comment.
Looks great, make sure not commit this CODEOWNERS in upstream contributions haha
Collaborator
Author
|
I almost did that... 😅 With these forked repos you also have to look twice which target branch you set for a PR.... |
johanvanderboom-tomtom
approved these changes
Jun 29, 2022
Collaborator
johanvanderboom-tomtom
left a comment
johanvanderboom-tomtom
left a comment
There was a problem hiding this comment.
Maybe for @BrunoCicciarello-TomTom, this will mean that you'll be added as reviewer and get email for every PR / comment. This will likely be low traffic since there are normally not that many changes, but just incase you don't want this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@FelixFaassen-TomTom, does this look good to you?